TheBackShed.com

Forum Index : Microcontroller and PC projects : Forum Improvement: How can I help?

Author

Message

LeoNicolas

Guru

Joined: 07/10/2020
Location: Canada
Posts: 479

Posted: 05:01am 06 Dec 2023

Copy link to clipboard

Print this post

Hello everyone

Is it possible to update the mobile forum view to have the image size from posts using the viewport width? Something like this:

img {
max-width: 100vw;
}

PS: I couldn't find a parent class for applying the CSS only to the post images.

I can make the changes and provide a pull request if I can have access to the source code repo.

JohnS
Guru

Joined: 18/11/2011
Location: United Kingdom
Posts: 3802

Posted: 09:29am 06 Dec 2023

Copy link to clipboard

Print this post

LeoNicolas said Is it possible to update the mobile forum view to have the image size from posts using the viewport width? Something like this:

img {
max-width: 100vw;
}

PS: I couldn't find a parent class for applying the CSS only to the post images.

Try the "contact me" to ask Glenn in case he doesn't see your post.

John

LeoNicolas

Guru

Joined: 07/10/2020
Location: Canada
Posts: 479

Posted: 03:58pm 06 Dec 2023

Copy link to clipboard

Print this post

No luck. The contact me link sent me to the about page which has several missing PHP include pages and no conact inormation.

JohnS
Guru

Joined: 18/11/2011
Location: United Kingdom
Posts: 3802

Posted: 07:36pm 06 Dec 2023

Copy link to clipboard

Print this post

LeoNicolas said No luck. The contact me link sent me to the about page which has several missing PHP include pages and no conact inormation.

Oh!

It used to work.

I will contact him and also PM you his email :)

John

LeoNicolas

Guru

Joined: 07/10/2020
Location: Canada
Posts: 479

Posted: 08:44pm 06 Dec 2023

Copy link to clipboard

Print this post

Thank you John

Gizmo

Admin Group

Joined: 05/06/2004
Location: Australia
Posts: 5078

Posted: 09:28pm 06 Dec 2023

Copy link to clipboard

Print this post

I usually do some work on the forum over Christmas.

An issue with resizing the images down to fit the mobile screen is you will loose detail, especially in things like circuit diagrams. I'll do a few tests.

I am willing to share the forum source code, but would like a fellow php developer to go over it first to make sure there are no vulnerabilities in the code.

Regards
Glenn

The best time to plant a tree was twenty years ago, the second best time is right now.
JAQ

LeoNicolas

Guru

Joined: 07/10/2020
Location: Canada
Posts: 479

Posted: 11:05pm 06 Dec 2023

Copy link to clipboard

Print this post

We can work with a pull request pipeline. Only reviewed code by the repo maintainers will be merged to the main branch.
This can ensure the code quality and security.

We can archive this with a private git repository with the main branch locked to direct changes.

I can help setting up something if necessary
Edited 2023-12-07 09:06 by LeoNicolas

LeoNicolas

Guru

Joined: 07/10/2020
Location: Canada
Posts: 479

Posted: 11:28pm 06 Dec 2023

Copy link to clipboard

Print this post

Gizmo said I usually do some work on the forum over Christmas.

An issue with resizing the images down to fit the mobile screen is you will loose detail, especially in things like circuit diagrams. I'll do a few tests.

I am willing to share the forum source code, but would like a fellow php developer to go over it first to make sure there are no vulnerabilities in the code.

Regards
Glenn

This change is only for mobile view and we can zoom in the image if we want to see more details or use the mobile landscape view. The current image size rendering on mobile doesn't work well

LeoNicolas

Guru

Joined: 07/10/2020
Location: Canada
Posts: 479

Posted: 05:27pm 11 Dec 2023

Copy link to clipboard

Print this post

Hello Gizmo

What are your thoughts on having the code in a private GitHub repository and allowing us to create pull requests?

Print this page

To reply to this topic, you need to log in.